Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODEOWNERS: exclude lib/maintainers.nix #31534

Merged
merged 1 commit into from Nov 16, 2017
Merged

CODEOWNERS: exclude lib/maintainers.nix #31534

merged 1 commit into from Nov 16, 2017

Conversation

lukateras
Copy link
Member

Motivation for this change

Resolves #31401.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 12, 2017

Maybe we could also exclude lib/licenses.nix the same way? Changes on this file are less frequent but additions or modifications on licenses are usually peer-reviewed during the PR process.

@orivej orivej merged commit 737e415 into NixOS:master Nov 16, 2017
lukateras added a commit to lukateras/nixpkgs that referenced this pull request Nov 16, 2017
@lukateras
maintainers: test PR (see NixOS#31534)
6df9d1e
@lukateras lukateras mentioned this pull request Nov 16, 2017
Closed
lukateras added a commit to lukateras/nixpkgs that referenced this pull request Nov 16, 2017
@lukateras
maintainers: verify that NixOS#31534 didn't break anything
66bb86c
@lukateras lukateras mentioned this pull request Nov 16, 2017
Closed
@lukateras
Copy link
Member Author

@cObw3B I wasn't sure that the trick with @ghost would actually work but #31755 and #31757 verified this. I'll open a new PR to ignore lib/licenses.nix as well.

@lukateras lukateras mentioned this pull request Nov 16, 2017
Merged
8 tasks
@lukateras lukateras deleted the patch-7 branch December 18, 2017 05:39
@aduth aduth mentioned this pull request Feb 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukateras @c0bw3b @orivej @GrahamcOfBorg