This repository has been archived by the owner on May 1, 2020. It is now read-only.
LB-242 / LB-241: Use BrainzUtils CustomFlask instead of Flask #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add custom_config.py.sample, default_config.py, test_config.py etc and change create_app to use CustomFlask, this should keep our version of Flask in track with the one in BrainzUtils. Also, upgraded BrainzUtils to v1.3.0
|
I should probably use the CustomFlask loggers now, instead of adding loggers later by hand. |
mayhem
approved these changes
Nov 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom_config.py.sample, default_config.py, test_config.py
etc and change create_app to use CustomFlask, this should keep
our version of Flask in track with the one in BrainzUtils.
Also, upgraded BrainzUtils to v1.3.0