New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tzdata: Use hard- instead of symbol-linking #31560
Conversation
I notice that 1f2228c changed from hard to soft links citing NAR issues. Is that relevant here? |
IIRC NARs don't preserve hardlinks, i.e. it's effectively as if you did a plain copy to most users, and the files being hardlinked will depend primarily on user's "optimising" their nix store. I don't know about any other issues. |
What software? What error? |
The standard library of the D programming language called Phobos. |
Ubuntu is using symlinking, but without loops. This is better: e75d458 |
I've pushed my fix to |
@FRidh Thank you, I was considering doing this myself. |
@orivej that was github; I merged staging into master. |
@FRidh My bad, I did not expect staging to be merged to master so soon. But please, configure git with |
Motivation for this change
Upstream software parses ${tzdata}/share/zoneinfo files.
Because of the symbolic posix link pointing to the local dir, the upstream software parses the contents of the zoneinfo directory multiple times because it follows symlinks and an error occurs because of this.
This PR changes the posix symlink to a hardlink to have a normal directory for posix like Fedora does.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)