Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

racket: reenable docs by default #31556

Merged
merged 1 commit into from Nov 13, 2017
Merged

racket: reenable docs by default #31556

merged 1 commit into from Nov 13, 2017

Conversation

gebner
Copy link
Member

@gebner gebner commented Nov 12, 2017

Motivation for this change

More than two years ago, @domenkozar disabled the documentation for racket in 89cec0c because of intermittent build failures. However this causes problems with raco, of course disables documentation in drracket, and breaks the documentation and help functions in emacs.

It seems like the build failures have been fixed now. So we should reenable docs by default.
cc maintainers @henrytill @vrthra

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@henrytill
Copy link
Member

I definitely support this (as long as we can live with the Travis timeouts).

@gebner gebner merged commit 82687ff into NixOS:master Nov 13, 2017
@gebner
Copy link
Member Author

gebner commented Nov 13, 2017

Ok, I'll merge this then. There shouldn't be any timeouts, the original issue was a non-deterministic exception when accessing an sqlite database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants