sway module: make it useful to end user #30800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
@GrahamcOfBorg wlc sway |
There was a problem hiding this comment.
build flags: -j1 -l1 SHELL=/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash
Scanning dependencies of target man-swaylock.1
[ 1%] swaylock.1
a2x: WARNING: --destination-dir option is only applicable to HTML based outputs
a2x: ERROR: "xsltproc" --stringparam callout.graphics 0 --stringparam navig.graphics 0 --stringparam admon.textlabel 1 --stringparam admon.graphics 0 "/nix/store/nlp6x6w8ypx829yrj48qxxkvv5zl3g8a-asciidoc-8.6.9/etc/asciidoc/docbook-xsl/manpage.xsl" "/tmp/nix-build-sway-0.14.0.drv-0/sway-0.14.0-src/build/bin/swaylock.1.xml" returned non-zero exit status 5
make[2]: *** [swaylock/CMakeFiles/man-swaylock.1.dir/build.make:61: bin/swaylock.1] Error 1
make[1]: *** [CMakeFiles/Makefile2:915: swaylock/CMakeFiles/man-swaylock.1.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for ‘/nix/store/s4c566rw5ndfyf32pnbfxx3kvz7m4hyv-sway-0.14.0.drv’ failed with exit code 2
error: build of ‘/nix/store/s4c566rw5ndfyf32pnbfxx3kvz7m4hyv-sway-0.14.0.drv’ failed
|
sway fails to build documentation: |
|
I really like this bot: @grahamc |
added 2 commits
October 25, 2017 21:51
|
@Mic92 Could you please also add https://github.com/gnidorah/nixpkgs/commit/e220dc265e1f710c111809896a25044e248145f5? This will be a go for people using default sway config. Thank you much! |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make
programs.swaymodule more useful. Now it's fine for starting sway directly from console which is recommended way to start sway https://github.com/swaywm/sway/wiki#login-managersThis way
services.xserveris not required at all (there is XWayland package if X11 compatibility is needed)Nevertheless
config.services.xserver.windowManager.swayefforts (#19663, #30493 (comment)) should not be phased out, since some people would prefer to use login manager as they may need to run some Xorg window manager in addition to sway or their setup relies on complex xsession procedure which display manager does. But for other cases it's far from ideal, since login managers depend on running Xorg.Change list
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)