Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid misleading error when using HTTP::Client form options #5185

Merged
merged 1 commit into from Oct 26, 2017
Merged

Avoid misleading error when using HTTP::Client form options #5185

merged 1 commit into from Oct 26, 2017

Conversation

luislavena
Copy link
Contributor

Restrict Hash types used by post_form, put_form and patch_form to avoid cryptic error messages when using a hash other than Hash(String, String).

Ref #5172
Ref #5184

Thank you.
❤️ ❤️ ❤️

@luislavena
Avoid misleading error when using HTTP::Client form options
c5d8543 
Restrict `Hash` types used by `post_form`, `put_form` and `patch_form`
to avoid cryptic error messages when using a hash other than
`Hash(String, String)`.

Ref #5172
Ref #5184
@Sija
Copy link
Contributor

Sija commented Oct 25, 2017

I think this PR should wait for #5139.

@luislavena
Copy link
Contributor Author

@Sija either way, it will require a rebase to adjust the change on method signature here or by @asterite on his PR.

I have no rush on getting this merged and not desperate for the other PR either 😄

Cheers.

@luislavena
Copy link
Contributor Author

@asterite or @RX14, can any of you trigger the rebuild on Travis? This shouldn't be failing but will be great to confirm.

Thank you 😄

asterite
asterite approved these changes Oct 26, 2017
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@asterite
Copy link
Member

Let's merge this first. I'll later rebase my PR.

@asterite asterite added this to the Next milestone Oct 26, 2017
@asterite asterite merged commit c79f437 into crystal-lang:master Oct 26, 2017
@luislavena luislavena deleted the restrict-http-client-form-hash-types branch October 26, 2017 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luislavena @Sija @asterite @RX14