Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma: 5.11.1 -> 5.11.2 #30794

Closed
wants to merge 1 commit into from
Closed

plasma: 5.11.1 -> 5.11.2 #30794

wants to merge 1 commit into from

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Oct 25, 2017 •
edited

Motivation for this change

KDE bugfix release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from ttuegel October 25, 2017 19:54
@bkchr
Copy link
Contributor

bkchr commented Oct 30, 2017

Works for me :)
@ttuegel any concerns?

@adisbladis
Copy link
Member Author

@peterhoeg pushed the same thing in 9ac793f so I'm closing…

@adisbladis adisbladis closed this Nov 2, 2017
@peterhoeg
Copy link
Member

Apologies all for not seeing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @bkchr @peterhoeg @FRidh