Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: crystal-lang/crystal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2d2ebac624d6
Choose a base ref
...
head repository: crystal-lang/crystal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 08aaa7b41699
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 23, 2017

  1. Honor no-color option from spec command 

    Prior this change, `crystal spec` only recognized `--no-color` when
provided as child command additional arguments.

This worked:

    $ crystal spec -- --no-color

However, this didn't:

    $ crystal spec --no-color

This change ensures that option specified to `spec` command is passed
to child process.

Fixes #1587
Ref #4292
    @luislavena
    luislavena committed Oct 23, 2017

    Verified

    This commit was signed with the committer’s verified signature.
    makenowjust Hiroya Fujinami
    GPG key ID: 9F4CB6A0CB6B6BE9
    Verified
    Learn about vigilant mode
    Copy the full SHA
    03bf122 View commit details

Commits on Oct 25, 2017

  1. Merge pull request #5168 from luislavena/pass-spec-no-color-option 

    Honor no-color option from `spec` command
    @asterite
    asterite authored Oct 25, 2017
    Copy the full SHA
    08aaa7b View commit details
Showing with 4 additions and 0 deletions.
  1. +4 −0 src/compiler/crystal/command/spec.cr
4 changes: 4 additions & 0 deletions src/compiler/crystal/command/spec.cr
View file
Original file line number Diff line number Diff line change
@@ -60,6 +60,10 @@ class Crystal::Command
end
end

unless @color
options << "--no-color"
end

source_filename = File.expand_path("spec")

source = target_filenames.map { |filename| %(require "./#{filename}") }.join("\n")