Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpodder: build XDG files #30802

Merged
merged 1 commit into from Oct 25, 2017
Merged

gpodder: build XDG files #30802

merged 1 commit into from Oct 25, 2017

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 25, 2017 •
edited

Motivation for this change

Installing desktop files will enable running the app from DE launchers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc maintainers @svenkeidel and @Mic92

@Mic92
Copy link
Member

Mic92 commented Oct 25, 2017

@GrahamcOfBorg gpodder

GrahamcOfBorg
GrahamcOfBorg reviewed Oct 25, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 


OK
Name                    Stmts   Miss  Cover
-------------------------------------------
gpodder/jsonconfig.py      95     50    47%
gpodder/model.py          691    643     7%
gpodder/util.py           762    605    21%
-------------------------------------------
TOTAL                    1548   1298    16%
/nix/store/abqm2nmsn64fnzzr5z4728ijjp9nmxix-gpodder-3.9.3

@Mic92 Mic92 merged commit b4c7d6b into NixOS:master Oct 25, 2017
@Mic92
Copy link
Member

Mic92 commented Oct 25, 2017

Thanks!

@Mic92
Copy link
Member

Mic92 commented Oct 25, 2017

also back ported.

@jtojnar jtojnar deleted the gpodder branch November 18, 2017 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @Mic92 @GrahamcOfBorg