Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 62.0.3202.75 -> 62.0.3202.89 #31417

Merged
merged 1 commit into from Nov 10, 2017
Merged

chromium: 62.0.3202.75 -> 62.0.3202.89 #31417

merged 1 commit into from Nov 10, 2017

Conversation

YorikSar
Copy link
Contributor

@YorikSar YorikSar commented Nov 9, 2017

Includes security fixes for CVE-2017-15398 and CVE-2017-15399.

Also fixes builds for beta and dev branches:

Motivation for this change
  • new stable version
  • security fixes
  • beta and dev build fixes
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@YorikSar
chromium: 62.0.3202.75 -> 62.0.3202.89
5f91cd1 
Includes security fixes for CVE-2017-15398 and CVE-2017-15399.

Also fixes builds for beta and dev branches:
- backport https://webrtc-review.googlesource.com/9384 to fix build for
  new webrtc revision
- for dev branch fix gn bootstrap, see
  https://chromium-review.googlesource.com/758584
- for 63+ manpage now is not generated during ninja build, it is
  processed with sed using packagers tools included in sources
@YorikSar
Copy link
Contributor Author

YorikSar commented Nov 9, 2017

@bendlas I've finally came around to fix all builds :)

@bendlas bendlas merged commit 7105bb6 into NixOS:master Nov 10, 2017
@bendlas
Copy link
Contributor

bendlas commented Nov 10, 2017

Wonderful! Thanks for taking this on, again!

@YorikSar
Copy link
Contributor Author

@bendlas No problem. Can you please also cherry-pick this commit to 17.09?

@orivej orivej added the 8.has: port to stable A PR already has a backport to the stable release. label Nov 10, 2017
@orivej
Copy link
Contributor

orivej commented Nov 10, 2017

He did in 8945fb1

@orivej
Copy link
Contributor

orivej commented Nov 10, 2017

@bendlas BTW please keep the reference to the commit in master by invoking git cherry-pick with -x.

@YorikSar
Copy link
Contributor Author

@orivej Oh, I must've missed that. @orivej @bendlas thanks!

@YorikSar
Copy link
Contributor Author

@orivej Oh, that's different one. This one updates from *.75 to *.89.

@orivej orivej added 9.needs: port to stable A PR needs a backport to the stable release. and removed 8.has: port to stable A PR already has a backport to the stable release. labels Nov 10, 2017
@bendlas
Copy link
Contributor

bendlas commented Nov 10, 2017

backported: 4fadb2f

@bendlas bendlas added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YorikSar @bendlas @orivej @GrahamcOfBorg