Skip to content

Commit

Permalink
lxc: Fix build error with glibc 2.26
Browse files Browse the repository at this point in the history
This issue doesn't necessarily have to do with glibc 2.26 and it could
have been fixed if we'd replace -Werror with -Wall.

The error in question was:

storage/overlay.c:808:13: error: 'dirlen' may be used uninitialized in
this function [-Werror=maybe-uninitialized]

After looking at the code in overlay.c it indeed might use dirlen
unitialized.

Unrelated to the glibc upgrade which brought the problem to the surface,
this also has been fixed upstream at lxc/lxc@180c477a326ce85632249ff169.

The reason however, that led to the upstream fix was a segfault which
has been reported at lxc/lxc#1802.

Signed-off-by: aszlig <aszlig@nix.build>
Cc: @wkennington, @globin, @fpletz
  • Loading branch information
aszlig committed Nov 9, 2017
1 parent e5bda93 commit 2a894cd
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkgs/os-specific/linux/lxc/default.nix
Expand Up @@ -29,6 +29,12 @@ stdenv.mkDerivation rec {

patches = [
./support-db2x.patch
# Fix build error against glibc 2.26
(fetchpatch {
url = "https://github.com/lxc/lxc/commit/"
+ "180c477a326ce85632249ff16990e8c29db1b6fa.patch";
sha256 = "05jkiiixxk9ibj1fwzmy56rkkign28bd9mrmgiz12g92r2qahm2z";
})
];

postPatch = ''
Expand Down

0 comments on commit 2a894cd

Please sign in to comment.