Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vista-fonts-chs: init at 1 #31420

Merged
merged 1 commit into from Nov 14, 2017
Merged

vista-fonts-chs: init at 1 #31420

merged 1 commit into from Nov 14, 2017

Conversation

ChengCat
Copy link
Contributor

@ChengCat ChengCat commented Nov 9, 2017

Motivation for this change

Add fonts for Simplified Chinese.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

meta = {
description = "TrueType fonts from Microsoft Windows Vista For Simplified Chinese (Microsoft YaHei)";
homepage = https://www.microsoft.com/typography/fonts/family.aspx?FID=350;
binaryDistribution = false; # haven't read the EULA, but we probably can't redistribute these files, so...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already covered, when unfree is set as license.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out. The commit is now updated.

@fpletz
Copy link
Member

fpletz commented Nov 14, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants