Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vista-fonts-chs: init at 1 #31420

Merged
merged 1 commit into from
Nov 14, 2017
Merged

vista-fonts-chs: init at 1 #31420

merged 1 commit into from
Nov 14, 2017
+48 −0

Conversation

ChengCat
Copy link
Contributor

@ChengCat ChengCat commented Nov 9, 2017 •
edited
Loading

Motivation for this change

Add fonts for Simplified Chinese.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ChengCat ChengCat requested review from edolstra and nbp as code owners November 9, 2017 07:30
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 9, 2017
Mic92
Mic92 reviewed Nov 10, 2017
View reviewed changes
pkgs/data/fonts/vista-fonts-chs/default.nix Outdated
meta = {
description = "TrueType fonts from Microsoft Windows Vista For Simplified Chinese (Microsoft YaHei)";
homepage = https://www.microsoft.com/typography/fonts/family.aspx?FID=350;
binaryDistribution = false; # haven't read the EULA, but we probably can't redistribute these files, so...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already covered, when unfree is set as license.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out. The commit is now updated.

@fpletz fpletz merged commit 6806dd3 into NixOS:master Nov 14, 2017
@fpletz
Copy link
Member

fpletz commented Nov 14, 2017

Thanks!

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@edolstra edolstra

@nbp nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ChengCat @fpletz @Mic92 @GrahamcOfBorg @Janik-Haag