Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two bower2nix bug fixes #30978

Merged
merged 2 commits into from Oct 30, 2017
Merged

Two bower2nix bug fixes #30978

merged 2 commits into from Oct 30, 2017

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Oct 30, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc @jluttine @shlevy @svanderburg

@rvl
fetchbower: clean common uri characters from version string
d0aa8b6 
Some bower.json files have URL dependencies missing a version.

Fixes rvl/bower2nix#18
@rvl
bower2nix: fix execution under nix-shell --pure
c717c2f 
bower2nix needs nix to compute store hashes.

Fixes rvl/bower2nix#16
@domenkozar domenkozar merged commit 9ec640e into NixOS:master Oct 30, 2017
@rvl
Copy link
Contributor Author

rvl commented Oct 30, 2017

Thanks @domenkozar

@rvl rvl mentioned this pull request Oct 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvl @domenkozar