Skip to content

Commit

Permalink
Don't parse "x:x" as a URI
Browse files Browse the repository at this point in the history
URIs now have to contain "://" or start with "channel:".
  • Loading branch information
edolstra committed Oct 30, 2017
1 parent 1299115 commit f90f660
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/libexpr/lexer.l
Expand Up @@ -90,7 +90,7 @@ FLOAT (([1-9][0-9]*\.[0-9]*)|(0?\.[0-9]+))([Ee][+-]?[0-9]+)?
PATH [a-zA-Z0-9\.\_\-\+]*(\/[a-zA-Z0-9\.\_\-\+]+)+\/?
HPATH \~(\/[a-zA-Z0-9\.\_\-\+]+)+\/?
SPATH \<[a-zA-Z0-9\.\_\-\+]+(\/[a-zA-Z0-9\.\_\-\+]+)*\>
URI [a-zA-Z][a-zA-Z0-9\+\-\.]*\:[a-zA-Z0-9\%\/\?\:\@\&\=\+\$\,\-\_\.\!\~\*\']+
URI [a-zA-Z][a-zA-Z0-9\+\-\.]*\:\/\/[a-zA-Z0-9\%\/\?\:\@\&\=\+\$\,\-\_\.\!\~\*\']+|channel\:[a-zA-Z0-9\%\/\?\:\@\&\=\+\$\,\-\_\.\!\~\*\']+


%%
Expand Down
2 changes: 1 addition & 1 deletion tests/lang/lib.nix
Expand Up @@ -49,7 +49,7 @@ rec {
if comp (head list2) (head list1) then [(head list2)] ++ mergeLists comp list1 (tail list2) else
[(head list1)] ++ mergeLists comp (tail list1) list2;

id = x: x;
id = x:x; # sic

const = x: y: x;

Expand Down
3 changes: 2 additions & 1 deletion tests/lang/parse-okay-url.nix
@@ -1,7 +1,8 @@
[ x:x
[
https://svn.cs.uu.nl:12443/repos/trace/trunk
http://www2.mplayerhq.hu/MPlayer/releases/fonts/font-arial-iso-8859-1.tar.bz2
http://losser.st-lab.cs.uu.nl/~armijn/.nix/gcc-3.3.4-static-nix.tar.gz
http://fpdownload.macromedia.com/get/shockwave/flash/english/linux/7.0r25/install_flash_player_7_linux.tar.gz
ftp://ftp.gtk.org/pub/gtk/v1.2/gtk+-1.2.10.tar.gz
channel:nixos-17.09
]

4 comments on commit f90f660

@vcunat
Copy link
Member

@vcunat vcunat commented on f90f660 Nov 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

channel:? I can't see it in https://www.iana.org/assignments/urn-namespaces/urn-namespaces.xhtml ;-)

Seriously, it's probably no use applying for registration, at least for now.

@grahamc
Copy link
Member

@grahamc grahamc commented on f90f660 Nov 1, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat
Copy link
Member

@vcunat vcunat commented on f90f660 Nov 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case we should reserve nix: while it's still free and use nix:channel:nixos-17.09 instead. EDIT: or perhaps we should give it some actual deep thought before applying.

@edolstra
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I don't really see a need for that.

Please sign in to comment.