Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cjdns: fix hash #30980

Merged
merged 1 commit into from Nov 1, 2017
Merged

cjdns: fix hash #30980

merged 1 commit into from Nov 1, 2017

Conversation

wizeman
Copy link
Member

@wizeman wizeman commented Oct 30, 2017

Motivation for this change

Fix cjdns hash.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

orivej
orivej suggested changes Oct 30, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as libgit2: #30982 (review)

@wizeman
cjdns: fix hash
7bd64e3 
.. and switch to fetchFromGitHub to avoid future hash changes.
@wizeman
Copy link
Member Author

wizeman commented Oct 30, 2017

Fixed as per @orivej's suggestion. Also removed reference to fetchpatch, as it doesn't seem to be used anymore.

Thanks!

@orivej orivej merged commit 26e4f6f into NixOS:master Nov 1, 2017
@wizeman wizeman deleted the u/fix-cjdns-hash branch December 1, 2017 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wizeman @orivej @GrahamcOfBorg