libgit2: fix hash #30982
Closed
libgit2: fix hash #30982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orivej
suggested changes
Oct 30, 2017
There was a problem hiding this comment.
This solution is incorrect because the hash of the archive will continue to change. Use fetchFromGitHub for GitHub archives (and fetchpatch for GitHub patches). (fetchzip also produces stable hashes, but its nix store path is unreadable, e.g. /nix/store/…-v0.25.1.)
... and switch to fetchFromGitHub to avoid future hash changes.
wizeman
force-pushed
the
u/fix-libgit2-hash
branch
from
3e5139c
to
3542041
Compare
|
Fixed as per @orivej's suggestion. Thanks! |
orivej
approved these changes
Oct 30, 2017
|
libgit2 0.25 is still needed for julia 05, so I've included your patch in #31119. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix libgit2 hash.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)