Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types.submodule: Replace a friendly comment by a more gentle one. #30961

Merged
merged 1 commit into from Oct 30, 2017
Merged

types.submodule: Replace a friendly comment by a more gentle one. #30961

merged 1 commit into from Oct 30, 2017

Conversation

nbp
Copy link
Member

@nbp nbp commented Oct 30, 2017

No description provided.

@nbp nbp requested a review from edolstra October 30, 2017 11:42
grahamc
grahamc reviewed Oct 30, 2017
View reviewed changes
lib/types.nix Outdated
# evaluation does not have any specific attribute name, we
# provide a default one for the documentation.
#
# This is mandatorry as some option declaration might use the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mandatorry

@grahamc
Copy link
Member

grahamc commented Oct 30, 2017

lgtm

@nbp
Copy link
Member Author

nbp commented Oct 30, 2017

typo fixed.

@nbp nbp removed the request for review from edolstra October 30, 2017 12:06
@nbp nbp merged commit d898713 into NixOS:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nbp @grahamc