Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pandas: 0.20.3 -> 0.21.0 #30956

Merged
merged 1 commit into from Oct 30, 2017
Merged

pandas: 0.20.3 -> 0.21.0 #30956

merged 1 commit into from Oct 30, 2017

Conversation

teto
Copy link
Member

@teto teto commented Oct 30, 2017

Now needs 'moto' to complete tests.

Motivation for this change

Current pandas test fail. It has bothered me for a while so I took the opportunity of seeing 0.21 to fix it.
I haven't seen moto being a new requirement so I added it just for the test.
http://pandas.pydata.org/pandas-docs/stable/whatsnew.html#whatsnew-0210

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto teto mentioned this pull request Oct 30, 2017
Closed
8 tasks
@NeQuissimus
Copy link
Member

Is this the expected number of passing tests? (not sure what "xfailed" means)

14946 passed, 719 skipped, 4 deselected, 12 xfailed, 1 xpassed, 1 warnings in 556.66 seconds

@orivej
Copy link
Contributor

orivej commented Oct 30, 2017

This number looks normal for pandas.

x in xfailed and xpassed signifies that the test was marked as "expected to fail".

@Moredread Moredread mentioned this pull request Oct 30, 2017
Closed
@orivej orivej merged commit 3c6bcab into NixOS:master Oct 30, 2017
@teto teto deleted the pandas branch October 30, 2017 14:56
@teto
pandas: 0.20.3 -> 0.21.0
d22a1f6 
Now needs 'moto' to complete tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @NeQuissimus @orivej