pcb: add features for orienting a case #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some round features on the sides to allow for lining up the PCB with an external case. Signed-off-by: Sean Cross <sean@xobs.io>
|
Could you attach a quick picture of the diff? |
|
|
|
The resolution of plastic features is about 1mm, so the divots are slightly bigger at 1.1mm each. The plan is to create a shell that slots into these divots, possibly gluing it on top if necessary. |
Signed-off-by: Sean Cross <sean@xobs.io>
This version has intendations for case alignment. This case assumes a PCB height of 0.6mm. Signed-off-by: Sean Cross <sean@xobs.io>
This corrects a problem with the edge dimension that was too short. Signed-off-by: Sean Cross <sean@xobs.io>
This case is more form-fitting, and goes around the MCU. Signed-off-by: Sean Cross <sean@xobs.io>
xobs
force-pushed
the
add-case-features
branch
2 times, most recently
from
5420bf0
to
4993d53
Compare
Signed-off-by: Sean Cross <sean@xobs.io>
xobs
force-pushed
the
add-case-features
branch
from
4993d53
to
17bac4a
Compare
The U1 GND pad got removed somehow. Add it back in. Signed-off-by: Sean Cross <sean@xobs.io>
Add generated gerber files for v0.3. Signed-off-by: Sean Cross <sean@xobs.io>
Signed-off-by: Sean Cross <sean@xobs.io>
|
Is this ready to merge? |
|
Yes it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some round features on the sides to allow for lining up the PCB with
an external case.