Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gmailieer: init at 0.3 #30957

Merged
merged 1 commit into from Nov 3, 2017
Merged

gmailieer: init at 0.3 #30957

merged 1 commit into from Nov 3, 2017

Conversation

KaiHa
Copy link
Contributor

@KaiHa KaiHa commented Oct 30, 2017

Motivation for this change

Add gmailier, a fast email-fetching and two-way tag synchronization between notmuch and GMail.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@danielfullmer
Copy link
Contributor

Small nitpick: The commit message should be "gmailieer: init at 0.3". Looks like you forgot an "e" and "Init" should be lowercased.
I can also confirm this works--I have a less-clean version in my own overlay here.

@KaiHa KaiHa changed the title gmailier: Init at 0.3 gmailieer: init at 0.3 Oct 30, 2017
@KaiHa
Copy link
Contributor Author

KaiHa commented Oct 30, 2017

Small nitpick: The commit message should be "gmailieer: init at 0.3". Looks like you forgot an "e" and "Init" should be lowercased.

Thanks for pointing this out, I have fixed this.

@orivej orivej merged commit 52a67e7 into NixOS:master Nov 3, 2017
@KaiHa KaiHa deleted the gmailieer branch November 3, 2017 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KaiHa @danielfullmer @orivej @GrahamcOfBorg