Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl: 5.24.2 -> 5.24.3 #30965

Merged
merged 1 commit into from Oct 30, 2017
Merged

perl: 5.24.2 -> 5.24.3 #30965

merged 1 commit into from Oct 30, 2017

Conversation

NeQuissimus
Copy link
Member

@NeQuissimus NeQuissimus commented Oct 30, 2017 •
edited

Motivation for this change

CVE-2017-12814
CVE-2017-12837
CVE-2017-12883

#30959

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Note
The binutils build segfaults for me, so I can't build perl -.-

@orivej orivej mentioned this pull request Oct 30, 2017
Closed
8 tasks
@vcunat
Copy link
Member

vcunat commented Oct 30, 2017 •
edited

Did the binutils segfault look like this?

stabs.c: In function '_bfd_link_section_stabs':
stabs.c:502:1: internal compiler error: Segmentation fault
 }
 ^

@vcunat vcunat self-assigned this Oct 30, 2017
@vcunat
Copy link
Member

vcunat commented Oct 30, 2017 •
edited

Well, I believe I've seen that segfault already, and it doesn't always happen even for me.

Perl news: https://metacpan.org/pod/release/SHAY/perl-5.24.3/pod/perldelta.pod EDIT: in particular, they claim there are no incompatible changes :-)

@vcunat vcunat changed the base branch from master to staging October 30, 2017 22:15
@vcunat vcunat merged commit d266a45 into NixOS:staging Oct 30, 2017
vcunat added a commit that referenced this pull request Oct 30, 2017
@vcunat
Merge #30965: perl: security 5.24.2 -> 5.24.3
9319019
@NeQuissimus NeQuissimus deleted the perl_5_24_3 branch October 30, 2017 23:14
vcunat added a commit that referenced this pull request Nov 1, 2017
@vcunat
Merge #30965: perl: security 5.24.2 -> 5.24.3
b45e466 
(cherry picked from commit 9319019)
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vcunat vcunat

Labels
1.severity: security 8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeQuissimus @vcunat @GrahamcOfBorg