Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-bootstrap: cleanup darwin expression #31125

Merged
merged 1 commit into from Nov 17, 2017
Merged

rust-bootstrap: cleanup darwin expression #31125

merged 1 commit into from Nov 17, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Nov 2, 2017

Motivation for this change

Some cleanup and fixes impurities in the rust bootstrap expressions for darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added this to Sandboxing in Darwin Nov 2, 2017
@LnL7 LnL7 mentioned this pull request Nov 3, 2017
Merged
8 tasks
@LnL7 LnL7 merged commit ccf7310 into NixOS:master Nov 17, 2017
@LnL7 LnL7 deleted the darwin-rust-bootstrap branch November 17, 2017 21:31
@veprbl veprbl moved this from Sandboxing to Done in Darwin Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
Darwin
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @GrahamcOfBorg