NixOS/zabbix-{server,agent}: 1.8 -> 3.4 wip #31123
Conversation
|
Feel free to take over as maintainer for Zabbix. I'm not using it anymore at the moment. |
| ${pkgs.postgresql}/bin/createuser --no-superuser --no-createdb --no-createrole zabbix || true | ||
| ${pkgs.postgresql}/bin/createdb --owner zabbix zabbix || true | ||
| ${pkgs.sudo}/bin/sudo -u postgres ${pkgs.postgresql}/bin/createuser --no-superuser --no-createdb --no-createrole zabbix || true | ||
| ${pkgs.sudo}/bin/sudo -u postgres ${pkgs.postgresql}/bin/createdb --owner zabbix zabbix || true |
There was a problem hiding this comment.
Maybe using runuser from utillinux is the better approach here or using su as below.
|
|
||
| let | ||
|
|
||
| version = "1.8.22"; |
There was a problem hiding this comment.
I don't think we need both zabbix versions. It also seems the old versions would not be maintained well.
|
Thank you both for the comments. I will take over as maintainer, remove the old versions and revamp the modules in the next week or so. :) |
|
This might be interesting when figuring out which versions to keep, and which to get rid of: https://www.zabbix.com/life_cycle_and_release_policy But if nobody has strong opinions on this, it's probably wasted to spend any effort on Zabbix 1.x and 2.x. |
|
we have merge conflicts here. |
|
OK, looks like I'll have to revive 2.0 and 2.2 for now... |
|
Wait, no, 2.0 is EOL. I'll revive 2.2 only and try and see if the modules still work. |
This reverts commit 8505c1c. pcre jit has been fixed
|
The Zabbix web service (nixos/modules/services/web-servers/apache-httpd/zabbix.nix) is currently broken. It seems the old Zabbix server isn't PHP 7 compatible and so it doesn't serve anything. Maybe for the better, I would be very surprised if it isn't full of known vulnerabilities.
|
|
I also no longer have to use Zabbix, closing. |
|
In the current state we probably should remove zabbix until someone maintains it properly. |
|
I've considered fixing it multiple times, but lost the will just by thinking about all the old cruft that had to be supported (v 1.8, 2.0, 2.2). If it was an acceptable solution to only support zabbix 3.4, then the task would be much easier. |
|
@adamtulinius Only supporting the newest is, at it stands, way more reasonable than having every version be unsupported, so please don't let that perceived requirement hold you back. :) |
Motivation for this change
Currently, the zabbix modules use a very old version of zabbix. Most of the mechanics appear to have been unaltered, but there are some fixes necessary to bring it to work with a current version. I'm unsure if this module is really used by anyone (because of its age.) If it isn't, I would like to rip it apart entirely and parameterize, among other things, the actual package version used by the module.
I notice that @edolstra is marked as maintainer, so I'm curious if you have strong feelings on keeping this module as-is, or whether I should take a less conservative approach than this on bringing it up-to-date.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)