Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmcs: 0.7.2 -> deprecated #31111

Merged
merged 2 commits into from Nov 1, 2017
Merged

libmcs: 0.7.2 -> deprecated #31111

merged 2 commits into from Nov 1, 2017

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 1, 2017

Motivation for this change

Part of #30636

The libmcs is deprecated upstream : homepage is dead and src URL is not available anymore.
That GitHub legacy repo is just as dead.

From an issue on a GitHub repo from the same organisation (Atheme) :

libmcs is deprecated and is no longer used in any atheme releases or third-party releases that we know of (e.g. audacious quit using it a long time ago).

And indeed : both GTK and Qt versions of audacious don't need that build input anymore (tested).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b requested a review from nbp as a code owner November 1, 2017 21:59
@globin
Copy link
Member

globin commented Nov 1, 2017

Please just remove the library :)

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 1, 2017 •
edited

@globin Done!

And nox-review completed successfully on nixos-17.09-small:

Result in /run/user/1000/nox-review-15zos4uu
total 0
lrwxrwxrwx 1 renaud users 59  1 nov.  23:23 result -> /nix/store/cwjwc7s50kfahxv74vflagq7wjjj7f4a-audacious-3.8.2
lrwxrwxrwx 1 renaud users 63  1 nov.  23:23 result-2 -> /nix/store/3fr2gvwil8fdw4g1rhkd744q8mv952f8-audacious-qt5-3.8.2
lrwxrwxrwx 1 renaud users 54  1 nov.  23:23 result-3 -> /nix/store/djk8a9849nkrxms5c6xlrkia0372dmb3-gjay-0.3.2

@vcunat vcunat self-assigned this Nov 1, 2017
@vcunat vcunat merged commit e2e8d59 into NixOS:master Nov 1, 2017
vcunat added a commit that referenced this pull request Nov 1, 2017
@vcunat
Merge #31111: remove libmcs
bb6257b
@c0bw3b c0bw3b deleted the pkg/libmcs branch November 1, 2017 23:55
@c0bw3b c0bw3b added this to To do in Picking up garbage via automation May 10, 2019
@c0bw3b c0bw3b moved this from To do to Done in Picking up garbage May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@nbp nbp Awaiting requested review from nbp

Assignees

@vcunat vcunat

Labels
None yet
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @globin @vcunat