Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxqt: 0.11.1 -> 0.12.0 #31115

Merged
merged 40 commits into from Nov 2, 2017
Merged

lxqt: 0.11.1 -> 0.12.0 #31115

merged 40 commits into from Nov 2, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Nov 2, 2017

Motivation for this change

Update LXQt to version 0.12.0

Release LXQt 0.12.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@romildo romildo requested a review from nbp as a code owner November 2, 2017 02:25
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@globin
Copy link
Member

globin commented Nov 2, 2017

Failing at:

In file included from /build/source/src/vm_viewer/qterminal/termwidgetholder.h:5:0,
                 from /build/source/src/vm_viewer/qterminal/term_mainwindow.h:7,
                 from /build/source/src/vm_viewer/lxc/lxc_viewer.h:5,
                 from /build/source/src/mainwindow.h:22,
                 from /build/source/src/main.cpp:1:
/build/source/src/vm_viewer/qterminal/termwidget.h:4:25: fatal error: qtermwidget.h: No such file or directory
 #include <qtermwidget.h>
                         ^
compilation terminated.
make[2]: *** [CMakeFiles/qt5-virt-manager.dir/build.make:2369: CMakeFiles/qt5-virt-manager.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:105: CMakeFiles/qt5-virt-manager.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/zln6cyr629byj0q3yxgag0iisr1s5rq9-virt-manager-qt-0.45.75.drv' failed with exit code 2

@romildo
Copy link
Contributor Author

romildo commented Nov 2, 2017

Keeping old version 0.7.1 of qtermwidget so that packages can use it until they are updated to use the new version.

@globin globin merged commit 0807f4a into NixOS:master Nov 2, 2017
@romildo romildo deleted the upd.lxqt branch November 2, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants