Support in.tftpd and gdb debugging in qemu #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The atftpd package is not available on fedora. The default tftpd package is in.tftpd. I have been using this and it works fine, although the logs may not be as nice. Allow the make file to fall back to use in.tftpd if atftpd is not available. Report an error if nothing is available.
In case we want to debug always keep open a gdb socket.
mithro
reviewed
Nov 1, 2017
Makefile
Outdated
| @@ -212,18 +212,31 @@ bios-flash: $(BIOS_FILE) bios-flash-$(PLATFORM) | |||
| # TFTP booting stuff | |||
| # -------------------------------------- | |||
| # TFTP server for minisoc to load firmware from | |||
| ATFTPD := $(shell which atftpd 2>/dev/null) | |||
| INTFTPD := $(shell which in.tftpd 2>/dev/null) | |||
There was a problem hiding this comment.
These will run every time the Makefile is opened which can make things slow. Could we instead do the if/then/else in shell inside the targets?
There was a problem hiding this comment.
Ah, right. I'll change it.
As suggested by mithro, this way the checks are not executed on every execution of the script. I am not so happy how this looks but it works ok now.
|
I have updated, not sure if you like the style but it seems to work ok. |
|
LGTM! Will just wait for CI to confirm things are still working and then I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not really related, but they were sitting in my repo when I started to update to latest upstream. I figured I clean them up and send upstream.