Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: refactor generic build function #31124

Merged
merged 1 commit into from Nov 2, 2017

Conversation

lo1tuma
Copy link
Member

@lo1tuma lo1tuma commented Nov 2, 2017

Motivation for this change

This removes some duplicated and dead code across the different versions of nodejs. I’ve tested the build and executed the binaries for all nodejs and nodejs-slim versions on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This removes some duplicated and dead code across the different versions of
nodejs.
@globin globin self-assigned this Nov 2, 2017
@globin globin merged commit ccbcf15 into NixOS:master Nov 2, 2017
@lo1tuma lo1tuma deleted the refactor-nodejs branch November 2, 2017 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants