Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selenium: 2.52.0 -> 3.6.0 #31114

Merged
merged 2 commits into from Nov 7, 2017
Merged

selenium: 2.52.0 -> 3.6.0 #31114

merged 2 commits into from Nov 7, 2017

Conversation

jraygauthier
Copy link
Member

Also brings into scope the geckodriver on which it depends.

Motivation for this change

Selenium was incompatible with latest firefox version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Related to #30186.

@disassembler
Copy link
Member

Can you move both of these to ../development/python-modules and use callPackage? We're trying to move away from having a bunch of package definitions in the top-level python file.

@jraygauthier
Copy link
Member Author

@disassembler : done.

@jraygauthier
Copy link
Member Author

As requested, moved selenium into its own file.

Also moved geckodriver into its own file and changeset and compiled it instead of taking binaries.

Added missing meta and multiple littles fixes.

@jraygauthier
Copy link
Member Author

I just looked at the unsucessful checks reported by travis. Those are totally unrelated. Odd.

@disassembler disassembler merged commit 3641da1 into NixOS:master Nov 7, 2017
@disassembler
Copy link
Member

a nox-review showed inginious as the only failing build, and it appears that's failing on master anyways. I'm good with this, merging!

@jraygauthier
Copy link
Member Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jraygauthier @disassembler @FRidh @GrahamcOfBorg