gixy: init at 0.1.8 #31574

WilliButz · 2017-11-12T22:12:53Z

gixy is a nginx static configuration analyzer.

Things done

also updated pythonPackages.ConfigArgParse to the most recent version (0.9.3 -> 0.12.0), as gixy depends on at least v0.11.0
added myself as maintainer
bumped certbot as the ConfigArgParse update broke the current version
bumped simp_le to the latest version (0.2.0 -> 0.6.0) as well because it depended on acme<0.12,>=0.11, which changed to 0.12 with the certbot update above
as requested I moved ConfigArgParse to development/python-modules and gixy to tools/admin

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested [acme] via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

WilliButz · 2017-11-12T22:43:33Z

This seems to break certbot 0.11.1, commit coming up :)

WilliButz · 2017-11-12T23:57:30Z

I added a section to handle the different dependencies for each supported python version which should fix the build errors from travis.

WilliButz · 2017-11-13T00:39:46Z

I am unable to reproduce the failing simp_le test as seen in travis :/

orivej · 2017-11-13T01:50:34Z

It fails only on Darwin, when trying to execute an empty script with #!/bin/sh shebang.

adisbladis · 2017-11-13T09:31:31Z

pkgs/top-level/python-packages.nix

@@ -8632,11 +8634,11 @@ in {

  ConfigArgParse = buildPythonPackage rec {


We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.

Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.

adisbladis · 2017-11-13T09:35:16Z

I think that gixy does not belong in pythonPackages since it's a cli-tool.
It should probably be in tools/admin.

WilliButz · 2017-11-13T18:40:37Z

@orivej I have set plaforms to linux as it this tool is not tested/officially supported on other OSes.

c0bw3b · 2017-11-14T17:44:25Z

👍 on updating simp_le since it's the backend for security.acme

disassembler · 2017-11-15T14:38:49Z

@GrahamcOfBorg build gixy

GrahamcOfBorg

Failure for system: x86_64-darwin

error: Package ‘gixy-0.1.8’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31574/pkgs/tools/admin/gixy/default.nix:40 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg

Success for system: x86_64-linux

tests.plugins.test_simply.test_from_config('alias_traversal', '/tmp/nix-build-gixy-0.1.8.drv-0/source/tests/plugins/simply/alias_traversal/simple.conf', {u'severity': [u'MEDIUM', u'HIGH']}) ... ok
tests.plugins.test_simply.test_from_config('alias_traversal', '/tmp/nix-build-gixy-0.1.8.drv-0/source/tests/plugins/simply/alias_traversal/not_slashed_alias.conf', {u'severity': [u'MEDIUM', u'HIGH']}) ... ok
tests.plugins.test_simply.test_from_config('alias_traversal', '/tmp/nix-build-gixy-0.1.8.drv-0/source/tests/plugins/simply/alias_traversal/not_slashed_alias_fp.conf', {u'severity': [u'MEDIUM', u'HIGH']}) ... ok
tests.plugins.test_simply.test_from_config('alias_traversal', '/tmp/nix-build-gixy-0.1.8.drv-0/source/tests/plugins/simply/alias_traversal/slashed_alias_fp.conf', {u'severity': [u'MEDIUM', u'HIGH']}) ... ok

----------------------------------------------------------------------
Ran 290 tests in 4.458s

OK
/nix/store/llxwkj0lyqa6i4xnj9nfjdyg8pyy0xwd-gixy-0.1.8

disassembler · 2017-11-15T15:11:53Z

Can you squash the 2 ConfigArgParse and the two gixy commits so there's just init at for gixy and old -> new for ConfigArgParse?

WilliButz · 2017-11-15T15:25:33Z

@disassembler I also rebased it to the current master

FRidh

Some minor changes are needed.

Furthermore, security.acme needs to be tested if its indeed impacted. cc @fpletz

FRidh · 2017-11-15T20:12:57Z

pkgs/development/python-modules/configargparse/default.nix

+  name = "ConfigArgParse-${version}";
+  version = "0.12.0";
+
+  src = fetchurl {


FRidh · 2017-11-15T20:13:34Z

pkgs/development/python-modules/configargparse/default.nix

+{ stdenv, lib, buildPythonPackage, fetchurl, pythonPackages }:
+
+buildPythonPackage rec {
+  name = "ConfigArgParse-${version}";


pname = "ConfigArgParse";
and drop the name attribute.
This is something new in buildPythonPackage.

FRidh · 2017-11-15T20:13:53Z

pkgs/development/python-modules/configargparse/default.nix

+  # no tests in tarball
+  doCheck = false;
+
+  meta = with stdenv.lib; {


license, description, maintainer?

As this package didn't have any maintainer before, I added myself and also a short description from the repo and the license.

FRidh · 2017-11-15T20:14:39Z

pkgs/tools/admin/gixy/default.nix

+{ lib, fetchFromGitHub, python, pythonPackages
+, python27Packages, python35Packages, python36Packages }:
+let
+  pyPkgs = (if python.pythonVersion=="3.5"


This needs to disappear. You can just use python.pkgs instead of pythonPackages.

FRidh · 2017-11-15T20:14:53Z

pkgs/tools/admin/certbot/default.nix

@@ -4,13 +4,13 @@

 python2Packages.buildPythonApplication rec {
  name = "certbot-${version}";
-  version = "0.11.1";


simp_le and thus security.acme need to be tested

I just ran the acme test successfully

FRidh · 2017-11-15T20:15:26Z

pkgs/tools/admin/gixy/default.nix

+  version = "0.1.8";
+
+  # package is only compatible with python 2.7 and 3.5+
+  disabled = !(lib.versionAtLeast python.pythonVersion "3.5"


pythonOlder or pythonNewer

I didn't find pythonNewer anywhere and used pythonAtLeast instead, which I guess you meant anyway.

FRidh · 2017-11-15T20:15:35Z

pkgs/tools/admin/gixy/default.nix

+
+  # package is only compatible with python 2.7 and 3.5+
+  disabled = !(lib.versionAtLeast python.pythonVersion "3.5"
+             || python.pythonVersion == "2.7");


FRidh · 2017-11-15T20:15:45Z

pkgs/tools/admin/gixy/default.nix

+    sha256 = "0dg8j8pqlzdvmyfkphrizfqzggr64npb9mnm1dcwm6c3z6k2b0ii";
+  };
+
+  patchPhase = ''


fpletz · 2017-11-17T14:31:06Z

We've done the simp_le bump already because the ToS hash of LetsEncrypt changed again. We need a rebase here.

…hon-modules - fetch with `fetchPypi` - add license, description and myself as maintainer

WilliButz · 2017-11-17T14:41:12Z

@fpletz rebased onto master again

WilliButz requested a review from FRidh as a code owner November 12, 2017 22:12

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 12, 2017

WilliButz force-pushed the add-gixy branch from dbab362 to 5975765 Compare November 12, 2017 23:54

FRidh added the 6.topic: python label Nov 13, 2017

adisbladis reviewed Nov 13, 2017

View reviewed changes

WilliButz force-pushed the add-gixy branch from 3a58441 to d82b9da Compare November 13, 2017 13:36

WilliButz changed the title ~~pythonPackages.gixy: init at 0.1.8~~ gixy: init at 0.1.8 Nov 13, 2017

WilliButz force-pushed the add-gixy branch from d82b9da to 48117c6 Compare November 13, 2017 18:37

c0bw3b added the 8.has: package (update) label Nov 14, 2017

c0bw3b added the 8.has: package (new) label Nov 14, 2017

GrahamcOfBorg reviewed Nov 15, 2017

View reviewed changes

GrahamcOfBorg approved these changes Nov 15, 2017

View reviewed changes

WilliButz force-pushed the add-gixy branch from 48117c6 to 6736d2c Compare November 15, 2017 15:24

FRidh requested changes Nov 15, 2017

View reviewed changes

WilliButz force-pushed the add-gixy branch from 6736d2c to d2eec55 Compare November 15, 2017 23:39

FRidh approved these changes Nov 16, 2017

View reviewed changes

fpletz added the 2.status: merge conflict label Nov 17, 2017

pythonPackages.ConfigArgParse: 0.9.3 -> 0.12.0, refactor, move to pyt…

c122dad

…hon-modules - fetch with `fetchPypi` - add license, description and myself as maintainer

gixy: init at 0.1.8

489fd5a

WilliButz force-pushed the add-gixy branch from d2eec55 to 489fd5a Compare November 17, 2017 14:39

fpletz merged commit bc7c2c2 into NixOS:master Nov 17, 2017

WilliButz deleted the add-gixy branch November 17, 2017 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gixy: init at 0.1.8 #31574

gixy: init at 0.1.8 #31574

WilliButz commented Nov 12, 2017 •

edited

WilliButz commented Nov 12, 2017 •

edited

WilliButz commented Nov 12, 2017

WilliButz commented Nov 13, 2017

orivej commented Nov 13, 2017

adisbladis Nov 13, 2017

adisbladis commented Nov 13, 2017 •

edited

WilliButz commented Nov 13, 2017

c0bw3b commented Nov 14, 2017

disassembler commented Nov 15, 2017

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

disassembler commented Nov 15, 2017

WilliButz commented Nov 15, 2017

FRidh left a comment

FRidh Nov 15, 2017

FRidh Nov 15, 2017

FRidh Nov 15, 2017

WilliButz Nov 15, 2017

FRidh Nov 15, 2017

FRidh Nov 15, 2017

WilliButz Nov 15, 2017

FRidh Nov 15, 2017

WilliButz Nov 15, 2017

FRidh Nov 15, 2017

FRidh Nov 15, 2017

fpletz commented Nov 17, 2017

WilliButz commented Nov 17, 2017

		@@ -8632,11 +8634,11 @@ in {

		ConfigArgParse = buildPythonPackage rec {

gixy: init at 0.1.8 #31574

gixy: init at 0.1.8 #31574

Conversation

WilliButz commented Nov 12, 2017 • edited

Things done

WilliButz commented Nov 12, 2017 • edited

WilliButz commented Nov 12, 2017

WilliButz commented Nov 13, 2017

orivej commented Nov 13, 2017

Choose a reason for hiding this comment

adisbladis commented Nov 13, 2017 • edited

WilliButz commented Nov 13, 2017

c0bw3b commented Nov 14, 2017

disassembler commented Nov 15, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

disassembler commented Nov 15, 2017

WilliButz commented Nov 15, 2017

FRidh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fpletz commented Nov 17, 2017

WilliButz commented Nov 17, 2017

WilliButz commented Nov 12, 2017 •

edited

WilliButz commented Nov 12, 2017 •

edited

adisbladis commented Nov 13, 2017 •

edited