Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configuration-ghc-7.10.x.nix: Remove missing attributes. #31603

Merged
merged 2 commits into from Nov 13, 2017
Merged

configuration-ghc-7.10.x.nix: Remove missing attributes. #31603

merged 2 commits into from Nov 13, 2017

Conversation

wizzup
Copy link
Contributor

@wizzup wizzup commented Nov 13, 2017 •
edited

Motivation for this change

Remove missing attributes since their existence cause errors and can not serve any purpose.

Please see the problematic command example in each individual commit message.

Things done
  • Remove missing attributes from nix expression file.
  • Problematic commands was running without any error.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@wizzup
remove missing attribute 'lens-family-th_0_4_1_0'
03cce16 
$ nix-env -f '<nixpkgs>' -qaPA pkgs.haskell.packages.ghc7103 -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/master.tar.gz
error: attribute ‘lens-family-th_0_4_1_0’ missing, at /nix/store/l7kr5m1h1rp16fh7d1m47caj2yj6xz4m-master.tar.gz/pkgs/development/haskell-modules/configuration-ghc-7.10.x.nix:161:20
@wizzup
remove missing attribute 'cabal-helper_0_6_3_1'
587219b 
$ nix-shell -p haskell.packages.ghc7103.ghc-mod -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/master.tar.gz
error: attribute ‘cabal-helper_0_6_3_1’ missing, at /nix/store/l7kr5m1h1rp16fh7d1m47caj2yj6xz4m-master.tar.gz/pkgs/development/haskell-modules/configuration-ghc-7.10.x.nix:211:53
@wizzup wizzup requested a review from peti as a code owner November 13, 2017 10:58
@peti peti merged commit b155ff6 into NixOS:master Nov 13, 2017
@wizzup wizzup deleted the fix-missing-haskell-attr branch November 15, 2017 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wizzup @peti @GrahamcOfBorg