nixos/tests: add a test for config.users.mutableUsers. #31569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in #31034, I think this PR is useful on its own. Waiting for review |
obadz
reviewed
Nov 19, 2017
nixos/tests/mutable-users.nix
Outdated
|
|
||
| # Machine starts in immutable mode. Add a user and test if reactivating | ||
| # configuration removes the user. | ||
| $machine->fail("cat /etc/passwd | grep foobar"); |
There was a problem hiding this comment.
Might want to make that grep ^foobar: instead
|
Added a comment on the code. Otherwise, LGTM. Given that this isn't part of |
It's in preparation to add an assertion for NixOS#4990.
gleber
force-pushed
the
add-mutable-users-test
branch
from
afc35b7
to
1dd0379
Compare
|
LGTM. Deferring to @fpletz. |
|
@GrahamcOfBorg @grahamc I've ran |
|
Thanks! |
|
When seeing why the tests fail, make sure to be rebased on a recent master. That is how the tests are run, and sometimes this is caused by breakage already on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's in preparation to add an assertion for #4990.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)