Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing uninstantiate(ancestor) #5284

Merged
merged 1 commit into from Nov 24, 2017
Merged

Add missing uninstantiate(ancestor) #5284

merged 1 commit into from Nov 24, 2017

Conversation

makenowjust
Copy link
Contributor

Fixed #5281

@makenowjust
Copy link
Contributor Author

makenowjust commented Nov 13, 2017 •
edited

Unfortunately CI is failed on downloading LLVM. It is completely not related to this.

Thanks!

Sija
Sija reviewed Nov 14, 2017
View reviewed changes
spec/compiler/semantic/instance_var_spec.cr Outdated
end

class Bar(T) < Foo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: redundant line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@makenowjust makenowjust force-pushed the fix/crystal/5281-add-missing-uninstantiate branch from b1b932e to f53e1dc Compare November 15, 2017 02:23
@luislavena
Copy link
Contributor

@mverzilli or @bcardiff, can we get your seal of approval on this?

Thank you.
❤️ ❤️ ❤️

@mverzilli mverzilli merged commit c26c0e0 into crystal-lang:master Nov 24, 2017
@mverzilli mverzilli added this to the Next milestone Nov 24, 2017
@makenowjust makenowjust deleted the fix/crystal/5281-add-missing-uninstantiate branch November 24, 2017 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@bcardiff bcardiff bcardiff approved these changes

@mverzilli mverzilli mverzilli approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler
Projects
None yet
Milestone
0.24.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@makenowjust @luislavena @Sija @bcardiff @mverzilli @RX14