Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anki: Enable tests #31582

Merged
merged 2 commits into from Nov 13, 2017
Merged

anki: Enable tests #31582

merged 2 commits into from Nov 13, 2017

Conversation

adisbladis
Copy link
Member

Motivation for this change

Enable tests when building anki

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Nov 13, 2017

Would you like to convert this into buildPythonApplication using pythonPackages.callPackage, replace inherit with function arguments, remove the override of the list of phases, replace pythonPath with propagatedBuildInputs, and use checkInputs for the new dependencies?

Mic92
Mic92 reviewed Nov 13, 2017
View reviewed changes
pkgs/games/anki/default.nix Outdated

phases = [ "unpackPhase" "patchPhase" "installPhase" ];
phases = [ "unpackPhase" "patchPhase" "testPhase" "installPhase" ];
Copy link
Member

@Mic92 Mic92 Nov 13, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if fixupPhase does not do any harm here, please remove the explicit phases selection here.

@adisbladis
anki: Enable tests
8d6ec6b 
Convert package to use buildPythonApplication instead of mkDerivation
@adisbladis
Copy link
Member Author

@orivej I thought about that too but didn't really want to since I don't use the package myself. Anyway, it has been done.

@Mic92 Mic92 merged commit d3cb4de into NixOS:master Nov 13, 2017
@orivej
Copy link
Contributor

orivej commented Nov 13, 2017

Thank you! BTW the difference between buildPythonPackage and buildPythonApplication is that the latter does not prepend python version to the name of the package. I've fixed it in a2bebdd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adisbladis @orivej @matthewbauer @Mic92 @GrahamcOfBorg