Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godot will crash if it is built with gcc6 #31587

Closed
wants to merge 1 commit into from
Closed

godot will crash if it is built with gcc6 #31587

wants to merge 1 commit into from

Conversation

jascase901
Copy link
Contributor

see issue #31584

Motivation for this change

I was experiencing a crash

Things done

I tested this on the 17.09 branch with nix-shell -i nixpkgs=~/nixpkgs -p godot --pure

With that godot binary I no longer experienced the crash outlined in issue #31584 .

It should be noted that without the --pure option godot still seemed to link against gcc-6 and crashed...

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jascase901 jascase901 mentioned this pull request Nov 13, 2017
Closed
8 tasks
@orivej orivej added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 13, 2017
Mic92 pushed a commit that referenced this pull request Nov 13, 2017
@jascase901 @Mic92
godot: 2.1.3 -> 2.1.4
61b20e2 
When I tested this locally I had already merged in
pull #31587.

fixes #31588 #31587
@Mic92
Copy link
Member

Mic92 commented Nov 13, 2017

merged in 61b20e2

@Mic92 Mic92 closed this Nov 13, 2017
Mic92 pushed a commit that referenced this pull request Nov 13, 2017
@jascase901 @Mic92
godot: 2.1.3 -> 2.1.4
c19136c 
When I tested this locally I had already merged in
pull #31587.

fixes #31588 #31587

(cherry picked from commit 61b20e2)
@prusnak prusnak mentioned this pull request May 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jascase901 @Mic92 @orivej @GrahamcOfBorg