Make socket errors in socket_egress
non-critical.
#79
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Right now a socket error in
EthernetInterface::socket_egress
results in bothsocket_egress
andpoll
returning early, which preventssocket_egress
from processing other sockets andpoll
from processing ingress packets. For example, if a socket tries to send a packet to an unresolved host,inner.dispatch
returnsError::Unaddressable
, which shortcutssocket_egress
andpoll
, which prevents ingress sockets from being processed, and host's MAC from being resolved, while the socket exists.Solution: Make socket errors non-critical, a socket error shouldn't affect other sockets or ingress packet processing.
Other: I'm not sure if this is the best solution, but the problem is real, specifically the situation described above.