Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godot: 2.1.3 -> 2.1.4 #31588

Closed
wants to merge 1 commit into from
Closed

godot: 2.1.3 -> 2.1.4 #31588

wants to merge 1 commit into from

Conversation

jascase901
Copy link
Contributor

When I tested this locally I had already merged in
pull #31587.

Motivation for this change

upgrade

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jascase901
upgrades from 2.1.3 to 2.1.4
4b632d8 
When I tested this locally I had already merged in
pull #31587.
FRidh
FRidh reviewed Nov 13, 2017
View reviewed changes
pkgs/development/tools/godot/default.nix
@@ -4,13 +4,13 @@

stdenv.mkDerivation rec {
name = "godot-${version}";
version = "2.1.3-stable";
version = "2.1.4-stable";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

version = "2.1.4";
...
rev = "${version}-stable";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 8b0f2b2

@Mic92 Mic92 changed the title upgrades from 2.1.3 to 2.1.4 godot from 2.1.3 to 2.1.4 Nov 13, 2017
@Mic92 Mic92 changed the title godot from 2.1.3 to 2.1.4 godot: 2.1.3 -> 2.1.4 Nov 13, 2017
@Mic92
Copy link
Member

Mic92 commented Nov 13, 2017

Thanks, I made this one commit with #31587.

@Mic92 Mic92 closed this in 61b20e2 Nov 13, 2017
Mic92 pushed a commit that referenced this pull request Nov 13, 2017
@jascase901 @Mic92
godot: 2.1.3 -> 2.1.4
c19136c 
When I tested this locally I had already merged in
pull #31587.

fixes #31588 #31587

(cherry picked from commit 61b20e2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jascase901 @Mic92 @FRidh @GrahamcOfBorg