Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdupes: 20150902 -> 1.6.1 #31576

Merged
merged 1 commit into from Nov 13, 2017
Merged

fdupes: 20150902 -> 1.6.1 #31576

merged 1 commit into from Nov 13, 2017

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 12, 2017

Motivation for this change

The former Google Code now officially redirects to this GH repo and there has been new dev since.

The 'fdupes-jody' patchset became the jdupes fork : see #26920

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

then applies various actions to those sets, e.g.:
* remove some of the duplicates,
* turn all the files in a set into hardlinks.
<literal>fdupes</literal> searches the given path for duplicate files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why <literal>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's the command you would type in your shell

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you expect that some software will translate <literal> into something else, or that people will literally read <literal>fdupes</literal>?

Copy link
Contributor Author

@c0bw3b c0bw3b Nov 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand your question...
It's in the long desc and I expected it to be formatted like a command on https://nixos.org/nixos/packages.html
I'm pretty sure I've seen it done in another package longDesc but I may be wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, there is one package that uses <literal>, axolati from #30086, but there is no reason to expect that nixos website will replace it with formatting, and it is easy to check that nix-env --description prints it as is. These tags are only used in the documentation postprocessed with xsltproc, which certainly will not work on arbitrary longDescriptions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake then. Will remove.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. When I first saw it in axoloti I though it was just a mistake, but when I saw you use it I suspected that you knew why it's useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I really wanted to believe that we could do some text formatting in the description!
Turns out I fooled myself... 😼

@Mic92 Mic92 merged commit e05ece8 into NixOS:master Nov 13, 2017
@c0bw3b c0bw3b deleted the pkg/fdupes branch November 15, 2017 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants