Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugin: 2016.2.0 -> 2017.0.0 #31018

Merged
merged 1 commit into from Oct 31, 2017
Merged

hugin: 2016.2.0 -> 2017.0.0 #31018

merged 1 commit into from Oct 31, 2017

Conversation

paperdigits
Copy link
Contributor

@paperdigits paperdigits commented Oct 31, 2017 •
edited

Motivation for this change

Update hugin to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Oct 31, 2017

We prefer to select alternative versions in all-packages because it makes it easier to see what packages depend on alternative versions, and to switch the default version later. See e.g.

nixpkgs/pkgs/top-level/all-packages.nix

Line 11019 in 33c0dca

wxGTK = wxGTK30;

@paperdigits
Copy link
Contributor Author

Thanks @orivej , I've updated this pull request.

@orivej orivej merged commit 324cf24 into NixOS:master Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paperdigits @orivej