Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mht2htm: init at 1.8.1.35 #31020

Merged
merged 1 commit into from Oct 31, 2017
Merged

mht2htm: init at 1.8.1.35 #31020

merged 1 commit into from Oct 31, 2017

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Oct 31, 2017 •
edited

Motivation for this change

This is the first derivation to use lazbuild from lazarus to build a lazarus/fpc project so I'm throwing this out there to @7c6f434c.

Should we create a proper builder for these types of projects (there doesn't seem to many admittedly) or is the manual lazbuild invocation OK with you?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

7c6f434c
7c6f434c reviewed Oct 31, 2017
View reviewed changes
pkgs/tools/misc/mht2htm/default.nix Outdated

installPhase = ''
runHook preInstall
install -Dm755 mht2htmcl $out/bin/mth2htmcl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary is actually called mht2htmcl?

Also, isn't there a README or COPYING to copy into $out/share/doc/mht2htmcl ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary is actually called mht2htmcl?

Yes...

Also, isn't there a README or COPYING to copy into $out/share/doc/mht2htmcl

Good point.

@7c6f434c
Copy link
Member

I dunno if it is worth it to create a lazbuild wrapper with lazarusdir pre-set. Creating a buildPhase feels like an overkill, to be honest.

@peterhoeg
Copy link
Member Author

There isn't a lot of lazarus projects here anyway, so we could keep that change for later.

@7c6f434c
Copy link
Member

I guess it is a good idea to copy all the files that make any sense for the installed program (I generally assume copying the license is actually legally necessary), and then it seems fine — I agree about lazbuild.

@peterhoeg peterhoeg merged commit 3690563 into NixOS:master Oct 31, 2017
@peterhoeg
Copy link
Member Author

Thanks for your input @7c6f434c

@peterhoeg peterhoeg deleted the p/mht branch October 31, 2017 14:08
@peterhoeg peterhoeg restored the p/mht branch October 31, 2017 15:03
@peterhoeg peterhoeg deleted the p/mht branch November 1, 2017 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c left review comments

Assignees
No one assigned
Labels
10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @7c6f434c @GrahamcOfBorg