Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pykde4: init at 4.14.3 #30985

Closed
wants to merge 1 commit into from
Closed

pythonPackages.pykde4: init at 4.14.3 #30985

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2017

Motivation for this change

Was removed due #24548 but it builds now. And it should stay as long as possible, because pykde5 bindings were never finished!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Oct 30, 2017

Do these bindings work with Plasma and/or the newer KDE applications? Are you using these bindings?

@@ -0,0 +1,35 @@
{ kde, kdelibs, pythonPackages, kdepimlibs, shared_desktop_ontologies,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python bindings are just Python libraries and so should therefore be called from python-packages.nix, with the expression also living in python-modules.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh Done, thank you!

@ghost
Copy link
Author

ghost commented Oct 30, 2017

@FRidh Yes, I'm using them. Just tested, yes, they work under Plasma 5.

@ghost
Copy link
Author

ghost commented Nov 2, 2017

Going to try fix DLFCN error for >= python3.6

@ghost ghost closed this Nov 2, 2017
@ghost ghost reopened this Nov 2, 2017
@ghost ghost requested a review from nbp as a code owner November 2, 2017 07:15
@ghost
Copy link
Author

ghost commented Nov 2, 2017

Done

@@ -0,0 +1,49 @@
{ kdelibs4, pythonPackages, kdepimlibs, shared_desktop_ontologies,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you list the actual dependencies instead of the package set

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh This way?

@ttuegel
Copy link
Member

ttuegel commented Nov 15, 2017

And it should stay as long as possible, because pykde5 bindings were never finished!

Which packages depend on pykde4?

@ttuegel
Copy link
Member

ttuegel commented Nov 15, 2017

Don't know, but a lot of Python scripts use pykde4

Are any of them in Nixpkgs? I'm going to remove kdelibs4 in about 30 days when upstream ends all support. What is the case for keeping it until then?

@ghost
Copy link
Author

ghost commented Nov 16, 2017

Are any of them in Nixpkgs? I'm going to remove kdelibs4 in about 30 days when upstream ends all support. What is the case for keeping it until then?

I believe not, sorry. Just using pykde4 myself for scripts. I will try to make this package standalone.

@ghost
Copy link
Author

ghost commented Nov 19, 2017

@ttuegel Ok, done

meta = with stdenv.lib; {
platforms = platforms.linux;
description = "Python bindings for KDE";
license = "GPL";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a license or licenses from lib.licenses? "GPL" is ambiguous.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttuegel Done, thanks!

@ghost ghost closed this Dec 28, 2017
@ghost ghost deleted the pykde4 branch December 28, 2017 01:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants