New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.pykde4: init at 4.14.3 #30985
Conversation
Do these bindings work with Plasma and/or the newer KDE applications? Are you using these bindings? |
@@ -0,0 +1,35 @@ | |||
{ kde, kdelibs, pythonPackages, kdepimlibs, shared_desktop_ontologies, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python bindings are just Python libraries and so should therefore be called from python-packages.nix
, with the expression also living in python-modules
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FRidh Done, thank you!
@FRidh Yes, I'm using them. Just tested, yes, they work under Plasma 5. |
Going to try fix DLFCN error for >= python3.6 |
Done |
@@ -0,0 +1,49 @@ | |||
{ kdelibs4, pythonPackages, kdepimlibs, shared_desktop_ontologies, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you list the actual dependencies instead of the package set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FRidh This way?
Which packages depend on |
Are any of them in Nixpkgs? I'm going to remove kdelibs4 in about 30 days when upstream ends all support. What is the case for keeping it until then? |
I believe not, sorry. Just using pykde4 myself for scripts. I will try to make this package standalone. |
@ttuegel Ok, done |
meta = with stdenv.lib; { | ||
platforms = platforms.linux; | ||
description = "Python bindings for KDE"; | ||
license = "GPL"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use a license or licenses from lib.licenses
? "GPL"
is ambiguous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ttuegel Done, thanks!
Motivation for this change
Was removed due #24548 but it builds now. And it should stay as long as possible, because pykde5 bindings were never finished!
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)