openntpd: fix constraints feature on NixOS #30987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenNTPD constraints feature requires a valid chain of SSL certificates, but the default path in openntpd didn't match the one in NixOS. Unfortunately the configured certificate path becomes hardcoded into the binary, so this feature will likely still fail on other distributions/operating systems, unless the path coincides with the NixOS path or the user sets up a symlink.
disassembler
suggested changes
Oct 30, 2017
| @@ -17,6 +17,7 @@ stdenv.mkDerivation rec { | |||
| "--with-privsep-user=${privsepUser}" | |||
| "--sysconfdir=/etc" | |||
| "--localstatedir=/var" | |||
| "--with-cacert=/etc/ssl/certs/ca-certificates.crt" | |||
There was a problem hiding this comment.
Could you test and see if this still works with "${cacerts}/etc/ssl/certs/ca-bundle.crt". That would solve the problem on other operating systems.
There was a problem hiding this comment.
I don't believe it would, because the cacerts package contains a fixed set of standard certificates, but other operating systems may have a different set of certificates, and the user may even have added (or removed) their own certificates to the ones that came with their operating system.
|
also backported to 17.09. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The OpenNTPD constraints feature requires a valid chain of SSL
certificates, but the default path in openntpd didn't match the one in
NixOS.
Unfortunately the configured certificate path becomes hardcoded into the
binary, so this feature will likely still fail on other
distributions/operating systems, unless the path coincides with the
NixOS path or the user sets up a symlink.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)