Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-generate-config: enforce umask 0022, fixes #30954 #31007

Merged
merged 1 commit into from Nov 1, 2017
Merged

nixos-generate-config: enforce umask 0022, fixes #30954 #31007

merged 1 commit into from Nov 1, 2017

Conversation

lukateras
Copy link
Member

Motivation for this change

Enforce umask for purity, fixes #30954. Tested.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej merged commit efea96d into NixOS:master Nov 1, 2017
@orivej
Copy link
Contributor

orivej commented Nov 1, 2017

Thank you!

@lukateras lukateras deleted the nixos-generate-config/umask branch December 18, 2017 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos-generate-config not pure, depends on umask setting
2 participants
@lukateras @orivej