Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg-full: fix on darwin #31015

Merged
merged 1 commit into from Oct 31, 2017
Merged

ffmpeg-full: fix on darwin #31015

merged 1 commit into from Oct 31, 2017

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Oct 31, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@domenkozar domenkozar merged commit 0744e0d into NixOS:master Oct 31, 2017
@domenkozar domenkozar added the 6.topic: darwin Running or building packages on Darwin label Oct 31, 2017
@acowley acowley deleted the ffmpeg-full-darwin branch October 31, 2017 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acowley @domenkozar