Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust.md #31998

Merged
merged 1 commit into from Nov 24, 2017
Merged

Update rust.md #31998

merged 1 commit into from Nov 24, 2017

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Nov 24, 2017

Motivation for this change

Using rust instead of rustc cargo doesn't work in either systemPackages or nix-shell -p

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

Please amend the commit message to follow this template:
doc: <change description>

@vaibhavsagar
Copy link
Member Author

Sure, updated.

@adisbladis
Copy link
Member

adisbladis commented Nov 24, 2017

I'd prefer it to be more descriptive why you made the change. Mention what problem you were fixing :)

@vaibhavsagar
Copy link
Member Author

That's in the commit message.

Using `rust` instead of `rustc cargo` doesn't work in either `systemPackages` or `nix-shell -p`
@adisbladis
Copy link
Member

Thanks!

@vaibhavsagar vaibhavsagar deleted the patch-1 branch November 29, 2017 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants