Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudfoundry-cli: init at 6.32.0 #32003

Merged
merged 1 commit into from Nov 26, 2017
Merged

cloudfoundry-cli: init at 6.32.0 #32003

merged 1 commit into from Nov 26, 2017

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 24, 2017

Motivation for this change

Add the cloudfoundry cli app.

Note that though I'm putting myself as the maintainer of this package, I am really not a Go person, and I found that to be quite an impediment when getting this damn thing to compile.

Why 6.30.0 when latest is 6.33.0? 6.30.0 is the latest version that builds with Go 1.8 - I'm intending to immediately backport this to release-17.09 which has no buildGoPackage for Go 1.9 (and maybe we should leave it as such). We can give master a followup version bump afterwards if so desired.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Nov 24, 2017

Well done! I suppose we are going to update Go in release to 1.9 (#29173 (comment)), and now that there is a use, I'd submit a PR today.

orivej added a commit that referenced this pull request Nov 25, 2017
@orivej
go: buildGoPackage: 1.8 -> 1.9
87bfe2c 
See #29173, #32003 for the reasons to update buildGoPackage in the release.

(cherry picked from commit 1e0ec42)
@orivej
Copy link
Contributor

orivej commented Nov 26, 2017

Go 1.9 is now in the release-17.09 branch. Will you update the package?

@risicle
Copy link
Contributor Author

risicle commented Nov 26, 2017

Updated and rebased.

@orivej orivej changed the title cloudfoundry-cli: init at 6.30.0 cloudfoundry-cli: init at 6.32.0 Nov 26, 2017
@orivej orivej merged commit 8aab940 into NixOS:master Nov 26, 2017
@orivej
Copy link
Contributor

orivej commented Nov 26, 2017

Added bash completions; released in 0990eea.

@risicle
Copy link
Contributor Author

risicle commented Nov 27, 2017

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @orivej @GrahamcOfBorg