Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh-prezto: updating "4f19700" -> "221c6cd" #32004

Merged
merged 1 commit into from Dec 3, 2017
Merged

zsh-prezto: updating "4f19700" -> "221c6cd" #32004

merged 1 commit into from Dec 3, 2017

Conversation

garbas
Copy link
Member

@garbas garbas commented Nov 24, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Nov 25, 2017
View reviewed changes
pkgs/shells/zsh-prezto/default.nix Outdated
in stdenv.mkDerivation rec {
rev = "4f19700919c8ebbaf75755fc0d03716d13183f49";
stdenv.mkDerivation rec {
rev = "221c6cd1283654ba77db052ee27aef613395321c";
name = "zsh-prezto-2015-03-03_rev${builtins.substring 0 7 rev}";
Copy link
Member

@Mic92 Mic92 Nov 25, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the date and remove the revision from name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tnx, makes sense, i'll fix it

@garbas garbas merged commit 5ab47cc into NixOS:master Dec 3, 2017
@garbas garbas deleted the update-pretzo branch December 3, 2017 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garbas @Mic92 @pSub @GrahamcOfBorg