Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim: 0.2.0 -> 0.2.1 #31604

Closed
wants to merge 1 commit into from
Closed

neovim: 0.2.0 -> 0.2.1 #31604

wants to merge 1 commit into from

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Nov 13, 2017

Motivation for this change

Update Neovim and the python and ruby hosts. Now it should give more or less green nvim -c :CheckHealth even in a polluted environment (the ruby host will give some harmless warnings in rare cases where the parent environment uses binary gem extensions).

Would be nice if someone using it to edit python could verify this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@manveru manveru requested a review from FRidh as a code owner November 13, 2017 11:19
@Mic92
Copy link
Member

Mic92 commented Nov 13, 2017

duplicate of #31460

@manveru
Copy link
Contributor Author

manveru commented Nov 13, 2017

Guess I should talk with him about combining the changes then...

@disassembler
Copy link
Member

@manveru can this be closed or were there other changes in here you want to rebase with the other neovim PR being merged?

@manveru
Copy link
Contributor Author

manveru commented Nov 15, 2017

@disassembler @garbas will integrate my changes today if everything goes well. Otherwise I'll do a separate PR. This can be closed either way.

@manveru manveru closed this Nov 15, 2017
@garbas garbas mentioned this pull request Nov 16, 2017
8 tasks
garbas added a commit that referenced this pull request Nov 20, 2017
the code has been taken from #31604 and fixed so that :CheckHealth for
ruby provider is also green (ruby and gem are required to be in PATH).
@manveru manveru deleted the update-neovim branch November 30, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants