Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clisp_2_44_1, libsigsegv_25: delete #31617

Merged
merged 1 commit into from Nov 14, 2017
Merged

clisp_2_44_1, libsigsegv_25: delete #31617

merged 1 commit into from Nov 14, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Nov 13, 2017 •
edited

Motivation for this change

These files are obsolete and unused. CLISP 2.44.1 fails to build with glibc 2.26.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc @7c6f434c

@vcunat
Copy link
Member

vcunat commented Nov 13, 2017 •
edited

/cc maintainer @7c6f434c. EDIT: oops, I see the mention now.

@orivej
Copy link
Contributor Author

orivej commented Nov 13, 2017

@vcunat I tried to add him as a reviewer, but GitHub did not let me, I posted the PR and tried again, and finally I've edited the description.

@vcunat
Copy link
Member

vcunat commented Nov 14, 2017

For me the reviewers field is just "loading suggestions" forever and thus is unusable.

@7c6f434c
Copy link
Member

Oh well, apparently we have lost SBCL bootstrap anyway.

@7c6f434c 7c6f434c merged commit eac38d0 into NixOS:master Nov 14, 2017
@orivej orivej deleted the clisp branch December 4, 2017 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@7c6f434c 7c6f434c

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@orivej @vcunat @7c6f434c @GrahamcOfBorg