Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: disable for pull requests #31605

Merged
merged 1 commit into from Nov 13, 2017
Merged

travis: disable for pull requests #31605

merged 1 commit into from Nov 13, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 13, 2017

travis is too slow for us and confuse contributors, who think they have
to get travis tests green.
We have now pr bots instead.

also see: #6652

@FRidh
Copy link
Member

FRidh commented Nov 13, 2017

Can you also include the referred scripts.

travis is too slow for us and confuse contributors, who think they have
to get travis tests green.
We have now pr bots instead.
@Mic92
Copy link
Member Author

Mic92 commented Nov 13, 2017

travis-nox-review-pr.sh removed

@grahamc
Copy link
Member

grahamc commented Nov 13, 2017

@globin
Copy link
Member

globin commented Nov 13, 2017

👍

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2017

I agree with this too.
Travis jobs provided some level of information sometimes in the past but was not to be trusted entirely and now we get those informations from the different Borg checks.
And we can still run a nox-review on our own for the big PRs.

@Mic92 Mic92 merged commit a8a2c22 into NixOS:master Nov 13, 2017
@Mic92 Mic92 deleted the disable-travis branch November 13, 2017 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants