vim-plugins.vim-powerline: init at 2012-11-13 #31608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Nov 13, 2017
pkgs/misc/vim-plugins/default.nix
Outdated
| dependencies = []; | ||
| preFixup = '' | ||
| sed "s/\(let\ g:Powerline_cache_dir\ =\).*/\1\ \/var\/cache\//" \ | ||
| -i "$out"/share/vim-plugins/vim-powerline/plugin/Powerline.vim |
There was a problem hiding this comment.
/var/cache should not be writeable by users. Something in $HOME is preferred here.
Also the following should look more readable:
sed 's!\(let g:Powerline_cache_dir =\).*!\1/var/cache/!' \
-i "$out"/share/vim-plugins/vim-powerline/plugin/Powerline.vim
There was a problem hiding this comment.
I want to use $HOME/.vim as Powerline_cache_dir . To make sure it exist i tried to use this code
if [ ! -d "$HOME/.vim" ]; then
mkdir $HOME/.vim
fiin PreFixup
nix-sell gives the error:
mkdir: cannot create directory '/homeless-shelter/.vim': No such file or directory
There was a problem hiding this comment.
This must happen at run-time (when the plugins is actually loaded) and not at build-time (in the nix-build sandbox).
In vim script this could be achieved using the following code,
silent !mkdir -p ~/.vim/powerline.cache > /dev/null 2>&1
but probably it is better to ask upstream first to implement this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
vim plugin for better-looking, more functional vim statuslines
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)